search

FooSoft / yomichan

Japanese pop-up dictionary extension for Chrome and Firefox.
https://foosoft.net/projects/yomichan
Other
1.06k stars 213 forks source link

Sometimes scan key doesn't trigger under Firefox #1871

Open cyphar opened 3 years ago

cyphar commented 3 years ago

Description

Unfortunately I'm not sure how to reproduce this, but it happens from time to time in Firefox.

I have Shift configured as my scan key, but fairly regularly, it simply stops working (holding shift and moving it over words produces nothing). Refreshing tabs or opening a new tab, changing the scan key, and even a full restart of Firefox do not appear to solve the issue -- it seems to resolve itself semi-randomly (I'll check if it happens after complete reboot). However, because my laptop is a touch-screen I can still select words by tapping on them, so only the scan key is broken.

I have some other add-ons installed, but I'll try to reproduce it after disabling everything other than Yomichan.

Browser version Firefox 90.0.2, openSUSE Tumbleweed

Yomichan version Yomichan 21.6.30.2

Exported settings file yomichan-settings.zip

toasted-nutbread commented 3 years ago

Would be interesting to try reproducing with a key other than shift as well.

cyphar commented 3 years ago

Alright, I'll switch my scan key to Ctrl and see if it happens again.

cyphar commented 2 years ago

I've hit this problem again, and even if I set the scan key to "no key" nothing is scanned even after restarting Firefox.

I wonder if this is related to my docking setup -- I've noticed that Firefox appears to have somewhat buggy behaviour sometimes when I dock my laptop (the screen stops being redrawn for instance) which I've been meaning to report recently. I just managed to fix this issue again by docking and redocking my laptop (then restarting firefox because the redrawing issue popped up) -- but I'm really not sure how the two could be related. This happens even if I use the built-in keyboard (and besides, the keyboard plugged into the dock works fine when docking and undocking).

But then again, I'm fairly sure that I was triggering this issue without using my dock a few months ago so I'm not sure that it's entirely related to my docking setup...