Closed toasted-nutbread closed 2 years ago
Updated testing release
Hi @FooSoft , thanks for maintaining Yomichan!
I got a report on issues about this release. Currently, I am running version 21.10.31.0
updated on November 8, 2021.
The middle-click to open yomi-chan on japanese text is broken. Broken = the yomichan minibox flash for 0.3 seconds and disappeared.
The way I triggered it: jisho.org any japanese text, more than 1 time. Beyond one time, it'll start the "flash" of box.
To reproduce, you may do the same as above.
Let me know how I can produce some logs that may be helpful for debugging.
Can you export your settings file from the settings page and share it here?
Can you export your settings file from the settings page and share it here?
Sure, @toasted-nutbread , I'll share here.
{furigana}
{reading}
{pitch-accents} {pitch-accent-positions} {pitch-accent-graphs}
{sentence}
{glossary} {audio}" } }, "kanji": { "deck": "", "model": "", "fields": {} }, "duplicateScope": "collection", "fieldTemplates": "{{#*inline \"glossary-single\"}}\n {{~#unless brief~}}\n {{~#scope~}}\n {{~#set \"any\" false}}{{/set~}}\n {{~#each definitionTags~}}\n {{~#if (op \"||\" (op \"!\" @root.compactTags) (op \"!\" redundant))~}}\n {{~#if (get \"any\")}}, {{else}}({{/if~}}\n {{name}}\n {{~#set \"any\" true}}{{/set~}}\n {{~/if~}}\n {{~/each~}}\n {{~#unless noDictionaryTag~}}\n {{~#if (op \"||\" (op \"!\" @root.compactTags) (op \"!==\" dictionary (get \"previousDictionary\")))~}}\n {{~#if (get \"any\")}}, {{else}}({{/if~}}\n {{dictionary}}\n {{~#set \"any\" true}}{{/set~}}\n {{~/if~}}\n {{~/unless~}}\n {{~#if (get \"any\")}}) {{/if~}}\n {{~/scope~}}\n {{~#if only~}}({{#each only}}{{.}}{{#unless @last}}, {{/unless}}{{/each}} only) {{/if~}}\n {{~/unless~}}\n {{~#if (op \"<=\" glossary.length 1)~}}\n {{#each glossary}}{{#formatGlossary ../dictionary}}{{{.}}}{{/formatGlossary}}{{/each}}\n {{~else if @root.compactGlossaries~}}\n {{#each glossary}}{{#formatGlossary ../dictionary}}{{{.}}}{{/formatGlossary}}{{#unless @last}} | {{/unless}}{{/each}}\n {{~else~}}\n@VKen Issue is fixed in #2005, will be included before the stable release.
Thanks for the quick fix, much appreciated! I can't test it now unless it is released in the testing channel (can't install unsigned addons in normal firefox). Looking forward to the release
@FooSoft updated release to 21.10.31.1. Might be good to only update the testing release for now, and then after a day or so, update the stable release. (Gives some time to @VKen to verify the issue is gone on his end.)
Done!
Issue has been verified fixed in the testing release version 21.10.31.1
. Thanks!
In that case, it's probably good to push to stable also @FooSoft.
Done!
https://github.com/FooSoft/yomichan/releases/tag/21.10.31.1
General
Testing
Stable
Issues to address before stable