FooSoft / yomichan

Japanese pop-up dictionary extension for Chrome and Firefox.
https://foosoft.net/projects/yomichan
Other
1.06k stars 213 forks source link

Certain JMdict senses getting merged? #2090

Open Thermospore opened 2 years ago

Thermospore commented 2 years ago

Description Sense 1 and 3 got merged at some point (probably due to having identical text?) idk if the merge occurs in the dictionary conversion process (yomichan import) or in the extension itself image image

Yomichan version (last edit to that jmdict entry was 2021-11-13 05:51:10) image

Exported settings file Here is the copy of jmdict shown in the screenshots (generated with the latest version of yomichan import) jmdict_english_2022-01-16.zip

siikamiika commented 2 years ago

When processing the extracted jmdict_english.zip with the following script

import glob
import json

for file in glob.glob('term_bank*.json'):
    with open(file) as f:
        data = json.load(f)
    for item in data:
        if item[0] == "翻訳":
            print(file, item)

I get

term_bank_10.json ['翻訳', 'ほんやく', 'n vs', 'vs', 715, ['translation'], 1523400, 'P ichi news']
term_bank_10.json ['翻訳', 'ほんやく', 'n vs', 'vs', 714, ['deciphering', 'decoding'], 1523400, 'P ichi news']
term_bank_10.json ['翻訳', 'ほんやく', 'n biol', '', 713, ['translation'], 1523400, 'P ichi news']

So I assume that the bug is in Yomichan.