FooSoft / yomichan

Japanese pop-up dictionary extension for Chrome and Firefox.
https://foosoft.net/projects/yomichan
Other
1.07k stars 229 forks source link

[Feature Request] Text Translation: Convert numeric characters to kanji #2091

Open MarvNC opened 2 years ago

MarvNC commented 2 years ago

Sometimes there are dictionary entries that only have the kanji version of the entry included, and when you look up the expression in the wild it may be a number. For example, yesterday I came across 鯛も1人はうまからず which was not picked up by any dictionary, but the version with the kanji 一 showed up. This may also be helpful when using Yomichan to search readings counters and such.

chrome_鯛も一人はうまからず_-_Yomichan_Search_-_Google_Chrome_2022-03-20_15-10-40

stephenmk commented 2 years ago

You can add this functionality by adding a text replacement pattern (Settings > Translation > "Configure custom text replacement patterns...").

See also issue #1750

I think these would be nice to have as defaults, though

replacement

MarvNC commented 2 years ago

I thought about text replacement patterns, but I was trying to replace them all at once instead of using separate patterns for some reason. It's a bit clunky but that works, thanks. I do think it would be great as a default, yeah. Yomichan_Settings_-_Google_Chrome_2022-04-08_18-42-34