search

FooSoft / yomichan

Japanese pop-up dictionary extension for Chrome and Firefox.
https://foosoft.net/projects/yomichan
Other
1.04k stars 203 forks source link

Popup doesn't work in Orion browser on macOS #2196

Open percheperche opened 2 years ago

percheperche commented 2 years ago

Description Yomichan's popup doesn't work in Orion. From what I understand it's a web browser that uses Safari's toolkit, but supports Chromium and Firefox extensions. The problem is Yomichan doesn't work properly. You can import dictionaries and if you insert Japanese sentences in "Yomichan search" they're parsed correctly, with all the information from the imported dictionaries. The problem is the popup doesn't work at all. In reader.ttsu.app if you try to parse some text, at least it is "highlighted", but in other sites it doesn't do anything at all. I know this would require more work for the devs, but it's not like it isn't working at all so I felt like it was worth giving it a shot.

Browser version Orion version 0.99.114.2-rc

Yomichan version Yomichan 22.4.4.0

toasted-nutbread commented 2 years ago

This is potentially the same issue as this one, where <iframe>s pointing to extension URLs don't work properly. You could probably verify this by checking to see if there are errors in the developer console. The behaviour seems very similar to what I saw with Safari.

percheperche commented 2 years ago

This is potentially the same issue as this one, where <iframe>s pointing to extension URLs don't work properly. You could probably verify this by checking to see if there are errors in the developer console. The behaviour seems very similar to what I saw with Safari.

This is what I find opening the "console tab" after right click > inspect element:

Yomichan 22.4.4.0 has encountered a problem.
Originating URL: [redacted]
Error: Acknowledgement timeout (popupMessage)
_onError@user-script:184:4283:30
hunt-g commented 1 year ago

This is what I find opening the "console tab" after right click > inspect element:

Yomichan 22.4.4.0 has encountered a problem.
Originating URL: [redacted]
Error: Acknowledgement timeout (popupMessage)
_onError@user-script:184:4283:30

Try enabling advanced mode with the toggle in the bottom left of the Yomichan's settings page, then disabling 'Use secure popup frame URL' at the very bottom of the page.

It won't fix that error, but it should make the popup appear.