search

FooSoft / yomichan

Japanese pop-up dictionary extension for Chrome and Firefox.
https://foosoft.net/projects/yomichan
Other
1.05k stars 203 forks source link

Audio lookup fails in cryptpad when using embedded popup #2209

Open not-nocturnal opened 1 year ago

not-nocturnal commented 1 year ago

Description imageimage

Audio lookup seems to fail when highlighting words anywhere on cryptpad. I'm not sure exactly why it's happening or how to debug or fix it. It's working fine for me on all other webpages I've tried. I also tried using a 'local' server (yomichan-forvo-server), but that didn't work either.

If I had to guess, it would be something to do with https://docs.cryptpad.fr/en/dev_guide/client/inner.html possibly preventing the addon frame from communicating externally, but it's a little over my head.

Browser version Waterfox G4.1.4 (Gecko/Firefox 91.x)

Yomichan version 22.6.6.0

Edit: the native browser window setting does work, and is okay as a workaround in my case, but it's still a bit clunky.

toasted-nutbread commented 1 year ago

This has to do with the Content-Security-Policy header, where most sites seem to allow audio. The behaviour in general is a bit strange, since extensions will ignore some parts of CSP, but curiously this isn't ignored.