FooSoft / yomichan

Japanese pop-up dictionary extension for Chrome and Firefox.
https://foosoft.net/projects/yomichan
Other
1.06k stars 223 forks source link

[Feature Request] After deconjugation, show words from other dictionaries even if they don't have deconjugation info #2223

Open aiko-tanaka opened 2 years ago

aiko-tanaka commented 2 years ago

Scanning 唇を奪う gives this result:

Scanning 唇を奪った gives this result:

I'm guessing this is because 実用辞典 doesn't have deconjugation info for this particular entry.

I think it'd be better though if scanning 唇を奪った would still display 実用辞典's entry, even if 実用辞典 doesn't have the deconjugation info for that word (kind of like borrowing the deconjugation info from other dictionaries I guess), and the same behavior for anything that can be deconjugated.

I'm not sure if this would cause unwanted results to pop up (can't think of any word that'd cause that though), but this could be integrated as a feature you can toggle on/off I guess.

Thermospore commented 2 years ago

if you set a primary dict that has the inflection info (eg jmdict) and jituyou as a secondary then it can get pulled up

image

I wanna say I was the one that made the issue where this feature got added, but I can't find it

I've noticed some cases where it isn't working properly tho, I'll take note next time I notice

aiko-tanaka commented 2 years ago

Oh nice. How do I do that? couldn't find it on my settings page.

toasted-nutbread commented 2 years ago

Change Result grouping mode to Group related terms, then adjust Primary dictionary and Secondary dictionaries... (which appears below it).

aiko-tanaka commented 2 years ago

Thanks! It'd be nice though to have still have this as a separate feature.