search

FooSoft / yomichan

Japanese pop-up dictionary extension for Chrome and Firefox.
https://foosoft.net/projects/yomichan
Other
1.04k stars 200 forks source link

Add color option for structured content #2278

Closed KiwiCracker closed 1 year ago

KiwiCracker commented 1 year ago

Add support for the color property

It's nice to have some more variation aviable when it comes to designing dictionary-entries. A few basic color names can be used, or any valid RGBA value.

stephenmk commented 1 year ago

Since yomichan has light and dark modes, these styles might make text unreadable in one mode or the other. They could also potentially cause some accessibility issues (e.g. for users with color blindness). Just a couple things to consider.

KiwiCracker commented 1 year ago

Ah yes, the thing with color blindness. I didn't consider this. Thanks for pointing it out :) Well, I don't see a point in implementing it then, when it's just for fun basically, but it might be a hindrance of others. It's probably best to close this then.