search

FooSoft / yomichan

Japanese pop-up dictionary extension for Chrome and Firefox.
https://foosoft.net/projects/yomichan
Other
1.04k stars 203 forks source link

Recursive popups don't work on Microsoft Edge #231

Closed toasted-nutbread closed 3 years ago

toasted-nutbread commented 4 years ago

Recursive popups don't work on Microsoft Edge. The cause of this seems to be the following: https://github.com/FooSoft/yomichan/blob/64eed33e8890df33e3c4acb47c96f0e3c674bd3b/ext/bg/js/api.js#L221-L224

sender.frameId is undefined. I have looked briefly into this with little success. I will close this issue if I find a solution.

Documentation: Chrome, Firefox, Edge.

sebastiaanvdm commented 4 years ago

Assuming we're talking about the same thing, this no longer works in Chrome either. (I used to be able to click on words inside definitions, it was really handy with J-J dictionaries!)

toasted-nutbread commented 4 years ago

@thebasser123 I think that may be due to a different reason. That feature was (inadvertently) disabled by default when a setting was added to toggle it on/off.

I believe the option you are referencing is called "Enable search when clicking glossary entries", which is found under the "Popup Content Scanning Options" heading.

The feature I am referencing is the recursive popups, where multiple popups can be created. This feature can be enabled by changing "Maximum number of additional popups" to a value greater than 0. In action, this feature looks like the image below: image

sebastiaanvdm commented 4 years ago

Silly me... Thank you!

juanj commented 3 years ago

I'm facing this issue. Don't have much experience with browser extensions, but will like to help. @toasted-nutbread did you find any clue of why sender.frameId is undefined?

toasted-nutbread commented 3 years ago

Are you using Chromium-based Edge or Legacy Edge? Chromium-based Edge supports it, but you have to enable it in options by editing the option Maximum number of additional popups.

juanj commented 3 years ago

Oh. You are right. After increasing Maximum number of additional popups it works perfectly fine!

I was testing on Firefox and it worked out of the box, so I assumed it was a problem with Edge. But looking back into Firefox settings, Maximum number of additional popups was indeed different than 0. I should have changed it at some point.

Thanks!

toasted-nutbread commented 3 years ago

Closing as Legacy Edge is not planned on being supported anymore, since Chromium-based Edge supports the extension the same as Chrome.