FooSoft / yomichan

Japanese pop-up dictionary extension for Chrome and Firefox.
https://foosoft.net/projects/yomichan
Other
1.07k stars 231 forks source link

Yomichan Chrome extension isn't working with the android Kiwi Browser since version 20.5.22.0 #595

Closed Vikeo closed 4 years ago

Vikeo commented 4 years ago

Not sure if this is the best place to post this, but I'll try.

I've been using the Chromium based Kiwi Browser for the sole reason that Yomichan works excellent with it. But since 20.5.22.0 and 20.5.22.1 it stopped working. It turns on in the extension manager, but when I try to turn it on via the Yomichan On/Off button it always goes back to Off. If I go into the setting page the Active Profile box is empty, along with almost everything else, and no buttons work. Version 20.4.10.1 and back still works fine, but since the extension automatically updates I can't use it for very long before it updates to the newest version. I've tried the latest update on 2 phones, but both were Samsung S10e.

That is all I know about this issue, I'm not 100% sure if it's not a Yomichan issue, but I ran out of ideas to try and get it fixed so now I wrote here.

toasted-nutbread commented 4 years ago

Briefly testing myself, everything seems to work on Kiwi Browser 77.0.3865.92 and Yomichan 20.5.22.1 from the Chrome web store. Have you tried uninstalling the extension and reinstalling? How many dictionaries do you have installed?

Vikeo commented 4 years ago

I've uninstalled and reinstalled the extension a few times, but the same thing happens everytime. I don't get the chance to install any dictionaries. To get to the Yomichan Options I have to go to the "Extensions" menu in the browser, press "Details" on Yomichan and then press "Extension options". But I can't install any dictionaries or change anything else while I'm in the options.

On version 20.4.10.1 I had the JMdict (Egnlish), KANJIDIC (English), JMnedict and Kanjium Pitch Accents dictionaries installed.

Don't know if it helps, but here's a video of how it looks. https://photos.app.goo.gl/KmjiPC99sy8wN6cw8

When I add the extension to chrome it says that the download fails, but it seems to install anyway. If If I download the 20.5.22.0 or 20.5.22.1 CRX file from another website and install that it seems to give the same result as installing from the chrome store.

toasted-nutbread commented 4 years ago

You appear to be getting an error of some sort; it's quite hard to see, but the extension icon looks like it's showing this: image. This would also explain why everything is not working. However, I cannot reproduce this error, and remote debugging the Kiwi browser is finicky. I can try to provide a custom build to help debug the error, and/or provide a description of how to try and debug the current version (which may only work if you have Windows 10). I basically just need a way to see what the logs are, but there doesn't seem to be a way to do so from inside the browser. I'll try to set that up soon.

Vikeo commented 4 years ago

Ah yeah, completely missed that.

My PC is running Win10. I don't know a whole lot about debugging but If I get some kind of instructions I think I can manage to get the logs. I appreciate the help!

toasted-nutbread commented 4 years ago

Since the process to debug using what you currently have is more involved, let's try a debug release.

Package: yomichan-20.5.22.1-with-logging-1.zip Source: https://github.com/toasted-nutbread/yomichan/commits/20.5.22.1-with-logging

So you should be able to put this file onto your device, and then installing it by enabling "Developer mode" on the extensions page, clicking the "Load" button, and selecting the .zip file.

On the settings page, even if it doesn't work, there should be a link at the very bottom that leads to a log page. This page should contain a textbox and two buttons for copying/selecting the text. The textbox should contain some info about errors that have been logged. If you can get to that and copy what's in there, that could be helpful. image image

Vikeo commented 4 years ago

Ok, here's the log.

https://pastebin.com/PTk9K3FD

toasted-nutbread commented 4 years ago

Interesting. I think I know how to solve the issue; here is another testing build which logs some additional info and tries to avoid the issue. Try doing the same thing as before with this new version.

yomichan-20.5.22.1-with-logging-2.zip

Vikeo commented 4 years ago

https://pastebin.com/xL0CNxRZ

Still getting the 84100376-bfdab400-a9d9-11ea-931e-deacf02acd14.

toasted-nutbread commented 4 years ago

Whoops, forgot to handle the new case in some other code. Try this: yomichan-20.5.22.1-with-logging-3.zip

Vikeo commented 4 years ago

Now it works! Thank you so much for the help! Here's the the now now, just in case. https://pastebin.com/h76rwW44

toasted-nutbread commented 4 years ago

Great, thanks for your help as well. I'll make sure this issue gets fixed on the master release as well. If you're fine with using the working build from above, you can continue using that. Be aware that it probably won't automatically update.

Vikeo commented 4 years ago

Yeah, I think I'll keep using this build for a little while and keep an eye out for the update then!

toasted-nutbread commented 4 years ago

FYI @Vikeo, the dev version has been updated with the latest fixes, and the standard version typically gets updated ~1 week after.