FooSoft / yomichan

Japanese pop-up dictionary extension for Chrome and Firefox.
https://foosoft.net/projects/yomichan
Other
1.07k stars 231 forks source link

Text-to-speech issue #616

Closed grospoulpe closed 4 years ago

grospoulpe commented 4 years ago

Hi, I don't know if it is related to a chrome update or something, but, only Text-to-speech sources (Google text to speech) seems to work, now (it worked before)

If I try both Japanesepod or Jisho.org, I have no sound (bu I have with Google Text to speech voice) Chrome : Version 83.0.4103.106 (Official Build) (64-bit) Yomichan v20.5.22.1

Thanks for you help!

Have a nice day.

Here two configuration (one which is working with google because I remove the other sources) yomichan settings.zip

toasted-nutbread commented 4 years ago

Check the "Audio playback volume" option; the value is set to 200. You are getting an error because the browser doesn't like the value being outside the range of [0, 100]. I will implement a safe-guard to limit the value if it's out of range.

grospoulpe commented 4 years ago

OK, thank you for your answer (I messed up with the volume level but: I usually use chrome extension like Volume Booster (some pronunciations have pretty low volume, especially with Jisho.org; meanwhile some words like 市外局番 only have text-to-speech/google Audio and the volume level is not modified by that extension (the extension works with the other sources like JapanesePod/Jisho) Anyway, meanwhile, I rebooted my PC (+CCleaner), and now the Audio Option works again :) ) Thanks again for you answer! :)

toasted-nutbread commented 4 years ago

Text-to-speech audio is generated using a different method than the other audio methods, so it's not surprising that Volume Booster doesn't work for that. And as far as I can tell in my testing, trying to set Yomichan's volume above 100% won't affect how Volume Booster works.

Thanks for finding and reporting the issue; the out-of-range volume issue will be fixed in the next release.