FooSoft / yomichan

Japanese pop-up dictionary extension for Chrome and Firefox.
https://foosoft.net/projects/yomichan
Other
1.04k stars 203 forks source link

Yomichan icon is displayed with a red box of exclamation points #713

Closed Ceiyne closed 3 years ago

Ceiyne commented 3 years ago

In the past couple of weeks I've noticed that from time to time the Yomichan icon in the Google Chrome toolbar will display a red box with two exclamation points in it, like this: image If I mouse over it, the pop-up displays:

Yomichan - Error Has access to this site

If I click the Yomichan button, the red box goes away and the Yomichan icon returns to normal, and works fine. I'm not 100% sure, but I think that Yomichan is non-functional (no pop-up when mousing over Japanese text) while the red box is shown. I'll have to try to test that next time it occurs.

I haven't noticed a specific pattern of when this occurs. I've only noticed it on my Windows PC and not on my Chromebook, but I use Yomichan more on my PC so it's possible it's happening in both places.

Is there a log or something else I could check for more information to send you?

toasted-nutbread commented 3 years ago

Yeah, the "!!" typically indicates that an error occurred at some point. If the browser hasn't been restarted, the logs can be viewed as follows:

The positive is that these issues are typically not indicative of the extension being broken, but rather that something went wrong at some point and was recoverable. These things are hard to test for because they usually involve bizarre edge cases or browser bugs, so feel free to share any logs when you run into these issues. Longer term, I plan to add a more user-friendly method of viewing these logs.

Ceiyne commented 3 years ago

This issue didn't occur for a long time, but I had it today. Here's what I got out of the dev tools: image

I wasn't trying to use Yomichan on the site (xfinity.com) mentioned in the logs (but of course, it was enabled in the browser). While the red exclamation points were displayed, I was able to continue using Yomichan normally in other tabs.

toasted-nutbread commented 3 years ago

Yeah, I see what would be happening with that. Depending on how a SVG image is embedded into a webpage, it may be displayed as a full document, similar to an <iframe>. However, it's not the same as a standard HTML document, so things go wrong. I'll look into handling that as a special case.

Ceiyne commented 3 years ago

Thanks. No big deal for me, though. I just wanted to report it.

xerpi commented 3 years ago

I have the same issue, in case it helps: image