search

FooStudio / flutter_statusbar_manager

Flutter StatusBar Manager for iOS & Android
MIT License
192 stars 74 forks source link

migrate to null-safety #17

Open NarHakobyan opened 3 years ago

NarHakobyan commented 3 years ago

Hi guys, I migrated package to null safety, to be honest I think this library is no more maintainable so you can use null safety version directly from git.

flutter_statusbar_manager:
  git:
    url: https://github.com/NarHakobyan/flutter_statusbar_manager
    ref: master
amitkot commented 3 years ago

@NarHakobyan Oops, I missed your PR and created one for this as well. I will probably close mine. I suggest limiting the arguments in the library's functions to not accept null values. Adding an link below. Also, the example app required some change to its Podfile to build. I advanced the version number and added to the changelog file, which will help the maintainers push the update.

NarHakobyan commented 3 years ago

Hi @amitkot, yeah, it's not necessary to have nullable arguments. I have fixed it.

NarHakobyan commented 3 years ago

@amitkot are you still here? :D

rafaelmaeuer commented 3 years ago

@NarHakobyan thanks very much for your PR, I am using it for now unless something else is moving here... Do you have a solution for MissingPluginException(No implementation found for method setStyle on channel flutter_statusbar_manager) when using flutter web?

Edit: I found a solution using kIsWeb and created a PR: https://github.com/NarHakobyan/flutter_statusbar_manager/pull/1

amitkot commented 3 years ago

@NarHakobyan hi, missed your ping (a month ago). I'm still here, was working on other project. I'm closing my PR now.