Open atherdon opened 5 years ago
where can I find 100% working code on heroku?
you mean fake-api deployed at heroku? or you need access to settings at heroku account? URL saved in description of this repository
I will try to deploy to my heroku account this https://medium.com/@grantspilsbury/build-and-deploy-a-node-express-server-to-heroku-in-10-steps-70c936ab15dc simple code.
I can just add you as a collaborator. or i'm ok that you will try on your own. i think there is not something "big" happens. I think the latest version of express is just required some additional tuning. and it's not about our server setup or our heroku configuration
it's also not pressing issue for now. i mean if you can run server locally - it can wait
this article didn't make any different steps also
I fixed it
You can see it in my deploy on heroku https://rocky-island-20527.herokuapp.com/hello
i see it on PR build page ;) looks cool. merging. can you also apply the same changes at graphql-server?
btw, did you add any custom settings to heroku? i mean i deploy it automatically from github repo(lazy variant)
On Tue, Feb 5, 2019 at 9:07 PM Arthur Tkachenko < arthur.tkachenko.netweight@gmail.com> wrote:
i see it on PR build page ;) looks cool. merging. can you also apply the same changes at graphql-server?
I doesn't change any parameters in heroku It's problem was in server port and ip in server.js
Do you mean deploy graphql to heroku?
no, i mean you made some changes, and tests start to work. i assume code in the last 3 commits that you've made at tests we calling an url and it return a basic value - telling us that server is not dead. and at graphql we have a same expressjs setup, so it wouldn't be a problem for you.
Ok, I will do it
this is an error log from heroku server. for some reasons it didn't work pretty well