search

Food-Static-Data / food-datasets-csv-parser

csv parser that we're using for parcing few food datasets
0 stars 10 forks source link

Codeclimate warnings after PR#114 #117

Open atherdon opened 5 years ago

atherdon commented 5 years ago

i'm ready to merge it, but check codeclimate report https://codeclimate.com/github/GroceriStar/food-datasets-csv-parser/pull/114

Originally posted by @atherdon in https://github.com/GroceriStar/food-datasets-csv-parser/pull/114#issuecomment-523532479

as I think some issues was not addressed - we'll need to handle it as well @SyeedHasan

atherdon commented 5 years ago

i didn't review all of them, but we can discuss them here. I assume we can solve some of that problems

atherdon commented 5 years ago

The main issue with these notifications - they tend to be collected and later it's hard to solve them in bulk. This is why it better to address them now