search

Food-Static-Data / food-static-files-generator

Module that help to generate static JSON files with complex structure
3 stars 13 forks source link

Fix TODO at fileSystem#89 #188

Open atherdon opened 5 years ago

atherdon commented 5 years ago

Strings must use singlequote.

https://codeclimate.com/github/GroceriStar/food-static-files-generator/src/measurements.js#issue_5d3789ba3908c50001000088

atherdon commented 5 years ago

@ijb87 another small task

ijb87 commented 5 years ago

i don't see the measurements.js file in the src folder

atherdon commented 5 years ago

yeah, we moved out that files to projects3.0 folder.

for now @ijb87 you can fix this todo: https://github.com/GroceriStar/food-static-files-generator/blob/master/src/fileSystem.js#L89

atherdon commented 5 years ago

@ijb87 tell me if you started this task - because now we merged new chances and code line can change a bit

ijb87 commented 5 years ago

haven't started on it yet...I just remembered xD i'll start working on it, but to be clear, the task is to improve the getFileName method by shortening it?

atherdon commented 5 years ago

@ijb87 emm, nope.

At method save you should replace the default loop with a method from lodash library. for sure it should work after changes. you can also make more changes if you wish but be careful

ijb87 commented 5 years ago

@atherdon what do you mean by:

// - we just need to find a better way to rewrite a getFileName method

atherdon commented 5 years ago

@ijb87 it's hard to explain :) when I see that code - it's not perfect - my gut tells me that. show me few code changes and if it will require changes - i'll tell you.

again - everything here is related to pull requests - if you start something - that show me and I will be able to guide you forward

ijb87 commented 5 years ago

@atherdon I don't think I have permission to pull request...

atherdon commented 5 years ago

hmm, you should have a forked repository - and you'll have ability to open pull requests

atherdon commented 5 years ago

I even don't see this repository on your account, so please fork this repo first, then checkout it locally and then start to make your changes