Food-Static-Data / sd

Food static data wrapper
GNU General Public License v3.0
9 stars 14 forks source link

custom structures generator [Main task] #158

Open atherdon opened 5 years ago

atherdon commented 5 years ago

So, we have our fetch module. link: https://github.com/GroceriStar/groceristar-fetch (Check Readme there and 5 published articles). And it's an old plugin that we build with Vadim during the last 8 months. Right now it's time for changes, and we split fetch with sd repository into 2 parts, that is separated. It makes the code more robust and easy to maintain/extend the code.

actually, with changes from me, @hirdbluebird, @azaidi4, @EbrahimKreem we break fetch and fixing it right now...

So, the main reason why I mentioning all of you here is: 1) we'll move from fetch to sd repository part of the functionality, that will generate us the same data, BUT with different structures(like {a:a, b:b} to {a:a, more: {b:b}}). All of you have different skills and knowledge of our modules, so we'll need to split this big task into small chunks.

2) Vadim will curate all of you, so please notify him frequently. The same thing with code - as we'll have a lot of people that code here at the same time --> we need to sync your forks frequently. If there is some troubles with your knowledge with git/github - please mention this. it's not a problem and i'll help you to master it.

3) Elnur will work with tests, Ronnie will help him Wahaj right now dealing with the generation of a few files, Ahmad and Ebrahim, Eugene came from fetch repository, so they know about different methods that we have there.

Vadim knows everything about both of this repositories, so he is in charge.

Ask your questions

@azaidi4, @EbrahimKreem, @vadim9999, @ronniebhatt, @elnur004

atherdon commented 5 years ago

@pratikshagit @ankit-prgmr @ijb87 @ladysequel @ambikantpc1987 how things going? do you have questions/busy/anything? Should i update your tasks - tell me something - don't see that we're on the same page at this moment.

ambikantpc1987 commented 5 years ago

Hi @arthur Assign me my task from next week onwards.

On Tue, May 21, 2019, 1:50 PM Arthur Tkachenko notifications@github.com wrote:

@Pratikshagit https://github.com/Pratikshagit @ankit_prgmr @ijb87 https://github.com/ijb87 @ladysequel https://github.com/ladysequel @ambikantpc1987 https://github.com/ambikantpc1987 how things going? do you have questions/busy/anything? Should i update your tasks - tell me something - don't see that we're on the same page at this moment.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/sd/issues/158?email_source=notifications&email_token=AKLS4AKGXM5QXNW2FRRN6K3PWOWDLA5CNFSM4HGWPQ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV3ELXI#issuecomment-494290397, or mute the thread https://github.com/notifications/unsubscribe-auth/AKLS4AN47IQLI66OJKJOQYLPWOWDLANCNFSM4HGWPQ5Q .

atherdon commented 5 years ago

Eugene ships a few big pull requests in previous days. One of them upgraded our Readme file. So if someone need more details - updated readme file will help you a lot. With that changes we'll run soon a chain of module updates(current module, parent module then few of our projects, that works with our static data)

Our first major part, related to this task is #294 Eugene also fixed our basic tests setup, so our Q&A engineers can work on extending tests for our files. Right now we have only dummy tests, but I hope soon our tests will make our life more bug-free.

When we'll complete #294(graphql part) we'll be able to move forward work on our graphql server.

Then, more complex task will be to generate files with relations, that can be used in our groceristar frontend pages. Looking forward for that part with excitement.

Some other startupers interested to use our data at their projects. Most of them interested in recipes + nutritional data + good measurements. I'll think about it and maybe we'll adjust our plan a bit in a next few months.

Pratikshagit commented 5 years ago

Hi Arthur

This week and next week I am busy with some other stuff. I will let you know when to assign a task to me. Simultaneously I am getting familiar with Jest Testing.

Best Pratiksha

On Tue, May 21, 2019 at 4:20 AM Arthur Tkachenko notifications@github.com wrote:

@Pratikshagit https://github.com/Pratikshagit @ankit_prgmr @ijb87 https://github.com/ijb87 @ladysequel https://github.com/ladysequel @ambikantpc1987 https://github.com/ambikantpc1987 how things going? do you have questions/busy/anything? Should i update your tasks - tell me something - don't see that we're on the same page at this moment.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GroceriStar/sd/issues/158?email_source=notifications&email_token=AFNN7GUC6JRXBRAOZAJ7MZ3PWOWDLA5CNFSM4HGWPQ52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODV3ELXI#issuecomment-494290397, or mute the thread https://github.com/notifications/unsubscribe-auth/AFNN7GV7DUACJMS7H5GF4O3PWOWDLANCNFSM4HGWPQ5Q .

ijb87 commented 5 years ago

@atherdon I've been busy lately actually, but I'll work on my task when I have the time

wahaj-47 commented 5 years ago

@atherdon Woah, it’s a pretty big file. How about we use some sort of script to generate json from xlsx ?

atherdon commented 5 years ago

@atherdon Woah, it’s a pretty big file. How about we use some sort of script to generate json from xlsx ?

yep - it looks like a good plan. i think what we should do: 1) export as csv. 2) try different npm modules that can help to parse csv file https://www.npmjs.com/package/csv-parse https://www.npmjs.com/package/csv-parser https://stackoverflow.com/questions/23080413/library-recommendations-nodejs-reading-csv-file https://stackabuse.com/reading-and-writing-csv-files-with-node-js/ https://csv.js.org/parse/ https://dev.to/maheshkay/read-csv-file-using-node-js-29oc https://github.com/adaltas/node-csv

3) use one that will suits to our needs 4) at separated file we'll make our extraction and save to json(using generator script i assume) 5) tests

@wahaj-47

atherdon commented 5 years ago

@EbrahimKreem how things going? Do you need a new task?

atherdon commented 5 years ago

I assume today we'll finish our first part of this task: https://github.com/GroceriStar/sd/issues/158#issuecomment-494354446 then we'll publish it on npm, upgrade things at fetch, fake-api, graphql-server projects @Edebo then will start https://github.com/GroceriStar/graphql-server/issues/145

and we here will work with Groceristar project part. Similar to tasks for Graphql - a lot of stuff was coded before - we just moving necessary methods here and lighten up a fetch module.

brunocordeiro180 commented 5 years ago

Hi, my name is Bruno. I'm from Brazil. How can I help you guys?

atherdon commented 5 years ago

@brunocordeiro180 this is a task for you #384

siddharthp538 commented 5 years ago

Hi. I'm Siddharth. I'm a new member of this team. Really looking forward to learn from all of you here. Thanks.

brunocordeiro180 commented 5 years ago

@atherdon Can you give me another task?

atherdon commented 5 years ago

@brunocordeiro180 take a look https://github.com/GroceriStar/sd/issues/76#issuecomment-496706753,

atherdon commented 5 years ago

Thanks to everyone! image

uniyalprashant9 commented 5 years ago

Hello Everyone.

atherdon commented 5 years ago

@uniyalprashant9 xxx

atherdon commented 5 years ago

@etg624 not sure why - but your comment gone :(

AndrewSerra commented 5 years ago

Hi everyone, I'm Andrew. I'm new on this team from Turkey, studying in the US. Looking forward to learning a lot.

atherdon commented 5 years ago

Looks pretty, right?

image

0xamogh commented 5 years ago

Hello I'm Amogh. I have just joined this team. I am from Oman and studying in India. I have developing software for the last 4 years, but only now have started working with JavaScript. Hoping to learn a lot from you guys and hope I can be of value to this project! :)

atherdon commented 5 years ago

Today our work is featured at Hackernoon newsletter image

atherdon commented 5 years ago

I add a tool that will help to check our code quality each time someone making a pull request and Adebowale make a good work by fixing issues that our code has. Big thanks!

ijb87 commented 5 years ago

@atherdon I would like a task please

jacob-nooz commented 5 years ago

Hi Everyone. My name is Jan Strum. I've been coding for about a year, and I'm now starting my first internship with GroceriStar. I'm looking forward to getting to know and working with you all!

svr8 commented 5 years ago

Hi! I'm Shikhar Vaish. I have been practicing full stack development and will be joining GroceriStar as an intern. Happy to join the team and learn! 😃

vadim9999 commented 5 years ago

@svr8 Hi! I have a task for you https://github.com/GroceriStar/sd/issues/592

AnuragKapoor-CSEngineer commented 5 years ago

Hello, My name is Anurag Kapoor and I am a web developer from last 2 years and can work on both front end back end. Created project on Technology MEAN and MERN. Have knowledge of JavaScript, React,Node , Express, REST API and Mongo

atherdon commented 5 years ago

I think @AnuragKapoor-CSEngineer will be an awesome addition to our team. Working on task for you

AnuragKapoor-CSEngineer commented 5 years ago

Thank you sir, I am eagerly waiting for the task

saphal1998 commented 5 years ago

I will be working on this issue as well.

NathanielFaber commented 5 years ago

Hello Everyone. My name is Nate Faber. I'm a student in the US who is looking to improve his skills and work towards an interesting project.

ijb87 commented 5 years ago

Can I have a task?

atherdon commented 5 years ago

@ijb87 Sure, will check some

IamRaviTejaG commented 5 years ago

@atherdon Please assign me an issue to work on.

akshaj1999 commented 5 years ago

Hello Everyone. My name is Akshaj Juneja. I'm undergrad student and wants to improve my skills and do more development.

geeksambhu commented 5 years ago

Hello Everyone, My name is Shiva. Looking forward to a great learning opportunity.

ChukwuEmekaAjah commented 5 years ago

Hello! I'm Chukwuemeka. What's the way to go?

ghost commented 5 years ago

Hi, I'm Edward. Looking forward to working with you all!

anh212 commented 5 years ago

Hello everyone, my name is Andrew and I am excited to learn and further develop my skills with all of you!

SyeedHasan commented 5 years ago

Hi guys, I'm Syed. Looking forward to furnishing my development skills with all of you. I'll get started with the project and jump right in to developing some feature soon!

vadim9999 commented 5 years ago

Hi!

MinahilOvais commented 5 years ago

Hi, I'm Minahil. Looking forward to learning and working with you all!

oksanafrankiv commented 5 years ago

Hi! I'm Oksana. I'm excited to learn and work with all of you!

haoyxc commented 5 years ago

Hi I'm Cindy! Excited to be a part of this!

zhangted commented 5 years ago

Hey, I'm Ted

Mishra121 commented 5 years ago

Hello I'm Vibhu. I am from India. I have JavaScript development knowledge. Familiar with MERN stack. Hoping to learn a lot from you guys and want to contribute in the project

parthparmar7 commented 5 years ago

Hello I am Parth, I am from India. I have JavaScript knowledge and have knowledge of Vue and Node.

Excited to be here.

chrissmith012 commented 5 years ago

Hello everyone, my name is Chris and I am from the United States. Excited to work and learn with you all!

atherdon commented 5 years ago

@Mishra121 @parthparmar7 @chrissmith012 team, do you have tasks?