Food-Static-Data / sd

Food static data wrapper
GNU General Public License v3.0
9 stars 14 forks source link

Moving functions from groceristar-fetch [Loopback] #371

Open atherdon opened 5 years ago

atherdon commented 5 years ago

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Is it was created as task at GitHub issues? Please provide an issue number or link

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

Here is a list of functions that should be moved and working without bugs. From https://github.com/GroceriStar/groceristar-fetch/blob/master/src/projects/GS-Loopback/loopback.js need move to https://github.com/GroceriStar/sd/blob/master/generator/projects/GS-Loopback/loopback.js this list of functions:

Note

Some methods for generating Id for each object in array using function generateId(). For example in getFavoritesKey() https://github.com/GroceriStar/groceristar-fetch/blob/master/src/projects/GraphQL/graphQL.js#L38 using `generateId() https://github.com/GroceriStar/groceristar-fetch/blob/master/src/projects/GraphQL/graphQL.js#L43 In this repository (SD) you can findgenerateId()andgenerateDatein https://github.com/GroceriStar/sd/blob/master/src/utils.js. When you will be importinggenerateId()andgenerateDate()` use this

const { __generateDate, __generateId } = require('../../../src/utils')

Uncomment test for the function that you have moved in graphQL.test.js https://github.com/GroceriStar/sd/tree/master/generator/projects/GraphQL/test

vadim9999 commented 5 years ago

@atherdon why in fetch in loopback.js some method are commented? and one function we can move here

atherdon commented 5 years ago

it's @hirdbluebird did it