Food-Static-Data / sd

Food static data wrapper

GNU General Public License v3.0

9 stars 14 forks source link

json-schema modification [addon] #423

Closed atherdon closed 5 years ago

atherdon commented 5 years ago

1) Move json schemes into the separated variable outside of describe block. it will make tests looks less complicated 2) move out example into the separated file, move out scheme into the separated file - maybe it should be one file with 2 exported variables... 3) configure rollup bundler, so with build -> we copy only json files from data folder at build, and skip tests/schemas/examples...

22

AndrewSerra commented 5 years ago

@atherdon nevermind I have made tests for both that check all paths I'll open a pull request so you and @vadim9999 can see what I have done and if it is right.

vadim9999 commented 5 years ago

@AndrewSerra yes, create working variant and open PR

AndrewSerra commented 5 years ago

@vadim9999 Already done.

AndrewSerra commented 5 years ago

@atherdon It looks like we completed the tests, at least the ones I have noticed, should we start step 3?

atherdon commented 5 years ago

@AndrewSerra i think we should jump at another task with you. As you think this was done - i'll close this task. I separated a step 3 at #595, so we don't forget about it.

Thinking about your next tasks now

atherdon commented 5 years ago

@siddharthp538 do you need another task as well?

siddharthp538 commented 5 years ago

yes @atherdon