Open jayhendren opened 7 years ago
We can probably just deprecate this rule since in 13+ there is no error (other than maybe some confusion around notifications).
I'm ok with nuking this one if someone (@coderanger) wants to cut a PR that explains why this isn't an issue anymore and why we don't need it.
I get the same for
package 'python-xml' do
action :install
only_if { node['os_family'] == 'suse' && check_package(new_package).empty? }
end
with foodcritic 12.3.0
And here is
recipes/master.rb
up to the resource defined on line 17 (ruby_block[trigger jenkins ...]
):Foodcritic is complaining that the
ruby_block
resource is defined with a fixed name in a loop, but it's not defined in a loop. The previously defined resources are in a loop, which seems to trigger the issue. if I comment out either thenode['cub_jenkins']['plugins'].each
loop or theruby_block
resource, then foodcritic stops complaining.