Foodcritic / foodcritic

Lint tool for Chef cookbooks.
http://foodcritic.io
MIT License
408 stars 153 forks source link

Add FC097, FC098, FC099, and FC100 for deprecated mixin usage #677

Closed tas50 closed 6 years ago

tas50 commented 6 years ago

Signed-off-by: Tim Smith tsmith@chef.io

coderanger commented 6 years ago

Any reason to not make these all one rule?

tas50 commented 6 years ago

I considered making it one rule, but we'll have deprecation docs linked for these and the remediation for each is going to be different. Also if we ever deprecate a new mixin it would be less than cool to just add another one to the rule randomly. This makes it super explicit what we're checking and what failed. Also if the contents of the supermarket are any judge very few people are going to hit any of these. They're barely public APIs that weren't used much outside of Opscode.

coderanger commented 6 years ago

I'm mostly just concerned about rule sprawl, but I suppose that ship already sailed :-/

tas50 commented 6 years ago

The rules are pretty fine grained, but IMO that's a feature not a bug. The tags are where the sprawl needs to be contained. You shouldn't be disabling individual rules you should be disabling tags