search

Foodcritic / foodcritic

Lint tool for Chef cookbooks.
http://foodcritic.io
MIT License
408 stars 153 forks source link

FC094 fires on chef12 but shouldn't #688

Open jaymzh opened 6 years ago

jaymzh commented 6 years ago

FC094 is designed to get people to move away from filesystem2 in chef13 now that filesystem is the same... but it currently fires for Chef12 (-c 12.21.26, -c 12.13.37 etc) which is both incorrect and dangerous.

coderanger commented 6 years ago

We don't use the -c version to control which rules are active at all, that's handled via tags. Though if someone wants to send a PR for auto-controlling the chefN tags with that CLI option too, I would be down.

tas50 commented 6 years ago

I'd like us to get a bit smarter about how we handle versions. Using the CLI to do the right thing would be helpful.