search

Foodcritic / foodcritic

Lint tool for Chef cookbooks.
http://foodcritic.io
MIT License
408 stars 153 forks source link

FC005: Foodcritic complains about repetetive resource declarations, however resources differ by more than one attribute #740

Open sblaufuss opened 6 years ago

sblaufuss commented 6 years ago

This recipe started throwing FC005 errors when we changed the file location from using a local variable, catalina_base, to the chef attribute accessor node['bke_tomcat']['catalina_base'].

`remote_file "#{node['bke_tomcat']['catalina_base']}/cas/lib/memcached-session-manager-1.9.1.jar" do source 'http://repo1.maven.org/maven2/de/javakaffee/msm/memcached-session-manager/1.9.1/memcached-session-manager-1.9.1.jar' owner 'root' group 'root' mode '0644' action :create end

remote_file "#{node['bke_tomcat']['catalina_base']}/cas/lib/memcached-session-manager-tc8-1.9.1.jar" do source 'http://repo1.maven.org/maven2/de/javakaffee/msm/memcached-session-manager-tc8/1.9.1/memcached-session-manager-tc8-1.9.1.jar' owner 'root' group 'root' mode '0644' action :create end

remote_file "#{node['bke_tomcat']['catalina_base']}/cas/lib/spymemcached-2.11.1.jar" do source 'http://central.maven.org/maven2/net/spy/spymemcached/2.11.1/spymemcached-2.11.1.jar' owner 'root' group 'root' mode '0644' action :create end`

Gary-Armstrong commented 5 years ago

+1