search

Foodcritic / foodcritic

Lint tool for Chef cookbooks.
http://foodcritic.io
MIT License
408 stars 153 forks source link

--epic-fail/-f returns 0 for FC078 #777

Open cdstudios opened 5 years ago

cdstudios commented 5 years ago

Looks like epic-fail ignores FC078:

$ foodcritic -f any .
Checking 1 files
x
FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
$ $?
-bash: 0: command not found

But if you break some more rules:

$ foodcritic -f any .
Checking 1 files
x
FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
FC067: Ensure at least one platform supported in metadata: ./metadata.rb:1
FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
$ $?
-bash: 3: command not found
$ foodcritic --version
foodcritic 14.0.0
tas50 commented 4 years ago

Right now anything with the ~opensource gets ignored there. It was mostly to deal with constant complaints about FC078 failing for people.