search

Foohy / jazztronauts

Jazztronauts is a cooperative theft-em-up for Garry's Mod, also known as prop hunt 2.
124 stars 34 forks source link

Add setskin shortcut in setspeaker #152

Closed Commenter25 closed 1 year ago

Commenter25 commented 1 year ago

A quick time-saving idea I had while tweaking the dialogue. It's pretty common to use setskin right after setspeaker. This allows you to optionally do both at the same time. So instead of doing *setspeaker cat_singer* *setskin cat_singer 4*, you can just do *setspeaker cat_singer 4*. Saves typing, keeps things visually cleaner, and will probably save a fuckton of bytes. I also have it change the skin before changing the speaker, to cut down on a bit of flickering.

If this is merged, I'll convert things to the new syntax as I go along with dialogue changes. Or if it's preferred, I can do it now and add it onto this PR.

wertercatt commented 1 year ago

This might be better as a macro in gamemodes/jazztronauts/content/data/scripts_en/macros.txt instead of a new dialogue command.

Commenter25 commented 1 year ago

It's not a new command, it just adds onto what already exists. setspeaker and setskin work the same as they always have, and any previous usage of them will function the same. The only difference is that setspeaker now has an optional extra parameter.

wertercatt commented 1 year ago

That's good, it sounds like it would be useful then. I was just worried that it might break existing custom dialogue scripts which use the old formatting, such as the Russian translation found at https://github.com/Livelandr/jazztronauts-ruspatch.

Foohy commented 1 year ago

This is a super useful change to make that a nicer shorthand, should work without having to change anything. Thank you kindly!!