Foohy / jazztronauts

Jazztronauts is a cooperative theft-em-up for Garry's Mod, also known as prop hunt 2.
122 stars 35 forks source link

What happened to the custom loading screen? #195

Closed lazyRares closed 1 year ago

lazyRares commented 1 year ago

I just realized that the custom loading screen Jazztronauts used to have isn't present anymore. Did a GMOD patch break it?

Commenter25 commented 1 year ago

I believe it was removed because it tended to stay on people's Gmod install even after completely uninstalling Jazztronauts. So every loading screen would be the Jazztronauts loading screen. However, it may have been broken by a patch as well. I plan on looking into this myself eventually, possibly restoring it if I can fix that issue.

Foohy commented 9 months ago

Bumping just to say that it should be back now as of 8fe529779d85302012869c0ec3bc7e0797b4c139 and edfa773e2c7a79587b4c3df7ccebab8cb24417de. While I didn't explicitly disable it, there were two issues that was preventing it from working:

  1. At some point, it became a requirement that urls started with http:// or https:// or it just silent failed
  2. The code to unset the loadingurl in sandbox was running even inside the gamemode, causing only every-other mapload to actually show it because it'd just unset it if it was set.

Also it's now hosted off of github pages instead of my lil vps, so that's less burden on me + the html source in version control is actually representative of what's live.