Merging your changes in Pipedal mainline

[rerdavies]

I'm just about to push a Pipedal 1.2 commit with bookworm support on my repository. It's a huge push (almost 200 files changed, don't ask, the TLDR, Wifi P2P is not supported by the NetworkManager networking stack, so drastic steps were required). The push should happen before end-of-day.

I have done my best to included your commits, although I have manually merged rather than doing it through a pull request. I'm still not entirely comfortable with github, and it seemed easier to just do it rather than using pull requests workflow to negotiate changes on the commits that I didn't like. I promise to use github better (proper branching would have made it easier to pull the commits) in future work. :-/

I would also like to add your copyright to files affected. It matters, because any copyrights in the source are automatically added to the open-source copyright notices in the about box. And special priority is given to contributors to the project. The format for the notice should be either:

 Copyright (c) Your Name   

(current best practice) or

Copyright (c) 2024 Your Name

(because omitting the year grates with those of us who grew up under old copyright regimes). Both forms are legally correct.

I'm assuming your updates are licensed under the same MIT license I'm using. Please say so in your reply. If you really want to use a different license, that can be accomodates, as long as your license isn't GPL.

Let me know what copyright notice you'd like to use.

The following commits have been manually merged, pretty much verbatim:

Fix GxTuner never displaying notes

Fix banks white bg in dark mode

Fix socket port default config value

Fix bypass with midi not affecting audio

---

Fix uninstall script

• Your fixes included (plus additional directories cleaned), but the file has been renamed to install.sh to mach the convention used by other scripts. The original wasn't truly functional. But now it is.

Fix type error in PresetSelector

• I have rejected this change. I think the original code is correct. the type of value is number | string | undefined, and the documention specifies that "" means that no value is selected. Let me know if you disagree. My concern is that converting the instanceId to string will mean that subsequent === comparisons will fail in the onclick handler.

Fix some errors in docs

• Partially accepted. Stripping documentation relating to VS Code was rejected.

Fix ToobML gain control not disabling

• Postponed until I can commit my changes. I need to run your code through VS Code auto-formatter to determine what the actual changes were. And the original code is lethally dangerous. :-/ It's possible that I may do some serious rewriting to make it safer. I'll get working on merging your commit as soon as I can.

[maarthome]

Hi Robin,

Nice to see that you are back.... alive and kicking!!!

Regards, Maarten

[rerdavies]

What copyright notice would you like to apply?