search

For-0 / vocabustudy

Study Vocabulary, For Free.
https://vocabustudy.org
GNU General Public License v3.0
7 stars 4 forks source link

Create the help center #237

Closed grimsteel closed 2 years ago

grimsteel commented 2 years ago

Information about everything in Vocabustudy

github-actions[bot] commented 2 years ago

Visit the preview URL for this PR (updated for commit 1a7c8ea):

https://vocabustudyonline--pr237-help-center-yafsl3va.web.app

(expires Fri, 02 Dec 2022 00:48:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: d64695b447b7ec78a8acd497241db5b96c5f796b

grimsteel commented 2 years ago

dang... all checks?

There are literally only two and one depends on the other so yes. All checks But make sure to follow the code of conduct

ShreyanKhanna commented 2 years ago

what are the checks

ShreyanKhanna commented 2 years ago

dang... all checks?

There are literally only two and one depends on the other so yes. All checks But make sure to follow the code of conduct

oh mb im so sorry

PrakmO commented 2 years ago

@Nikhilatvocabustudy sorry but can you work on something else until I make sure this works? I kind of want to work on this one myself. This may not ping you because I'm on chromebook

PrakmO commented 2 years ago

Sorry I keep adding one enter instead of two since I am on VS Code on Chromebook

PrakmO commented 2 years ago

@grimsteel maybe squash some of them...

IMGROOT2 commented 2 years ago

I'm on a day trip to Toledo (google it lol), so I can't really edit. But I did manage to emulate it last night, and here are a few things that need to be changed:

  1. Add a centered title on the home page. Remove the text underneath "<- Vocabustudy" on the top left ("with tips, how-tos..."), the placement and design is a little unclean.

  2. Add element classes for mdc theme. Choosing dark mode right now makes text unreadable, as the text in the drop-down correctly changes to dark gray, but the background incorrectly stays a lighter gray.

  3. Grammar, and rewording. My department, I'll handle this.

  4. Add "management@vocabustudy.org", feedback+bugs google form, etc right underneath the "Help Center" centered title I explained in "1."

I think that's all I spotted. Again, there's not much on the page to begin with, but I'm sure it will become a helpful guide.

Ok I think we've reached Toledo. Byee

PrakmO commented 2 years ago

Added how to make a set

PrakmO commented 2 years ago

Sorry for the not specific commit messages

PrakmO commented 2 years ago

I'm on a day trip to Toledo (google it lol), so I can't really edit. But I did manage to emulate it last night, and here are a few things that need to be changed:

  1. Add a centered title on the home page. Remove the text underneath "<- Vocabustudy" on the top left ("with tips, how-tos..."), the placement and design is a little unclean.
  2. Add element classes for mdc theme. Choosing dark mode right now makes text unreadable, as the text in the drop-down correctly changes to dark gray, but the background incorrectly stays a lighter gray.
  3. Grammar, and rewording. My department, I'll handle this.
  4. Add "management@vocabustudy.org", feedback+bugs google form, etc right underneath the "Help Center" centered title I explained in "1."

I think that's all I spotted. Again, there's not much on the page to begin with, but I'm sure it will become a helpful guide.

Ok I think we've reached Toledo. Byee

ok done

PrakmO commented 2 years ago

I'm on a day trip to Toledo (google it lol), so I can't really edit. But I did manage to emulate it last night, and here are a few things that need to be changed:

  1. Add a centered title on the home page. Remove the text underneath "<- Vocabustudy" on the top left ("with tips, how-tos..."), the placement and design is a little unclean.
  2. Add element classes for mdc theme. Choosing dark mode right now makes text unreadable, as the text in the drop-down correctly changes to dark gray, but the background incorrectly stays a lighter gray.
  3. Grammar, and rewording. My department, I'll handle this.
  4. Add "management@vocabustudy.org", feedback+bugs google form, etc right underneath the "Help Center" centered title I explained in "1."

I think that's all I spotted. Again, there's not much on the page to begin with, but I'm sure it will become a helpful guide.

Ok I think we've reached Toledo. Byee

Well I didn't make the "Vocabustudy Help Center" title centered because none of the other pages have centered titles and it didn't look good

grimsteel commented 2 years ago

It looks good for the most part! Here are some minor changes:

I will probably squash merge this PR bc of the sheer number of commits...

grimsteel commented 2 years ago

Um why did package-lock.json get updated? (If you could partially that commit that would be great - something like that is better updated in package.json also and on the main branch

grimsteel commented 2 years ago

I resolved the merge conflicts but I will update the deps in main after this is merged

PrakmO commented 2 years ago

It looks good for the most part! Here are some minor changes:

  • [x] Make the email address into a link
  • [x] Fix the title image
  • [x] Add an OG description (Look at the other pug files for inspiration)
  • [ ] Maybe add more info on study guides and the other study modes?

I will probably squash merge this PR bc of the sheer number of commits...

I'll add more stuff after we merge

grimsteel commented 2 years ago

I'll add more stuff after we merge

Why not before? (just asking)

IMGROOT2 commented 2 years ago

Um why did package-lock.json get updated? (If you could partially that commit that would be great - something like that is better updated in package.json also and on the main branch

Whoops I'm sorry, I must have not unchecked that before commit and push. I'm actually travelling to Granada today, so there's no chance of me getting on my laptop. Can someone else please revert it for me? Thank you, and sorry about that.

But yes we should definitely update the package versions

grimsteel commented 2 years ago

Can someone else please revert it for me?

No worries - already done

IMGROOT2 commented 2 years ago

ty!

PrakmO commented 2 years ago

I'll add more stuff after we merge

Why not before? (just asking)

I can before too

PrakmO commented 2 years ago

No reason

grimsteel commented 2 years ago

@DG3QRT1 Do you want to delete this PR and make a new one? (This one is owned by me which is inconvenient as I can't review it)

PrakmO commented 2 years ago

@DG3QRT1 Do you want to delete this PR and make a new one? (This one is owned by me which is inconvenient as I can't review it)

ok