For-Science / Crypto-For-Science

Crypto For Science is a crowdfunding platform that uses the spirit of cryptocurrency in order to fund scientific research: no fees and no intermediaries - all the funds go directly to the researchers.
MIT License
20 stars 6 forks source link

"Donations" collection/publication would make more sense being called "Donation Claims" #1

Closed LDubya closed 6 years ago

LDubya commented 6 years ago

The "Donations" collection is slightly misnamed, as it's really set up to store donation claims. To remove ambiguity (since "Donations" is very likely to be the name for the collection used to help calculate cryptocurrency donation totals for projects -- currently being done manually by spreadsheet), I think the collection should be renamed to DonationClaims.

This is really not that complex, just kind of time-consuming as it boils down to renaming a bunch of strings in different locations. Great way to make a contribution and become familiar with a large portion of the code base.

rename folders:

/imports/api/donations/ -> /imports/api/donationClaims/

etc...

rename variables:

etc...

rename files:

etc...

refactor

etc...

test

make sure it works by submitting a donation claim for a project and then logging in as the project owner and approving/rejecting that donation claim


Comment below if you plan to submit a pull request for this

ctvanzandt42 commented 6 years ago

I'll take this issue on! Expect a pull request in the coming days.