search

For-a-few-DPPs-more / structure-factor

Compute structure factor of stationary and isotropic point processes
https://for-a-few-dpps-more.github.io/structure-factor/
MIT License
10 stars 5 forks source link

Confusing duplicate Hankel transform using Ogata method #5

Closed dhawat closed 3 years ago

dhawat commented 3 years ago

https://github.com/For-a-few-DPPs-more/structure-factor/blob/011e3c6b4b5a37f454f1136ca2db2caccc812e3d/src/structure_factor/transforms.py#L188

guilgautier commented 3 years ago

Functions following the definitions of Hankel transform classes correspond to old code that might have been commented or even deleted.

The function you mention https://github.com/For-a-few-DPPs-more/structure-factor/blob/011e3c6b4b5a37f454f1136ca2db2caccc812e3d/src/structure_factor/transforms.py#L188 is a standalone implementation of Ogata's method for computing hankel transform type of integrals.

The object counterpart https://github.com/For-a-few-DPPs-more/structure-factor/blob/011e3c6b4b5a37f454f1136ca2db2caccc812e3d/src/structure_factor/transforms.py#L96 allows us to store intermediate quantities that may be reused for the subsequent computation of Hankel transform type integrals.