search

ForEvolve / bootstrap-dark

Bootstrap 4 dark theme that supports togging dark/light themes as well. There is no fluff, it changes the color of Bootstrap and that's it, no new thing to learn or unlearn, just Bootstrap, but Dark!
MIT License
299 stars 44 forks source link

Dark and light theme - double css code #20

Closed piernik closed 2 years ago

piernik commented 5 years ago

First - great work. Dark theme is something that is missing in bootstrap!

One concern. If I want to add both light and dark theme there is much css code because for dark theme You attach all bootstrap code second time with different colors.

Is it possible to make much smaller dark theme (which needs light theme) that contains only changed colors, not whole bootstrap code?

Carl-Hugo commented 5 years ago

Thanks, a dark theme is indeed missing from the official release; once you go dark, you can't come back to the light 😉

That said, yes, it should be possible to do what you ask for. It would require quite a bit of work tho (I think). If you want to get to it, I'll be happy to help you out as much as I can, get some initial specs outlined, review your PR, and test your updates. Unfortunately, I'm too busy to do it myself at this time.

That said, optimizing is important, but unless your visitors are using very slow internet, both toggle-bootstrap*.min.css size is not that big: 453 KB (235 for the dark one and 218 for the regular one). Then with client-side caching, it's a one-shot download.