Reboot classes included in both themes

ForEvolve / bootstrap-dark

Bootstrap 4 dark theme that supports togging dark/light themes as well. There is no fluff, it changes the color of Bootstrap and that's it, no new thing to learn or unlearn, just Bootstrap, but Dark!

MIT License

299 stars 44 forks source link

Reboot classes included in both themes #49

Closed prymitive closed 2 years ago

prymitive commented 3 years ago

When using bootstrap-dark reboot styles are included under .bootstrap {} (see https://github.com/ForEvolve/bootstrap-dark/blob/master/scss/toggle-bootstrap.scss#L20), the side effect is that they might be more specific then extra classes imported and so override them. An example is using FontAwesome icons that use .fa-xxx on svg elements for extra styling, those styles are overwritten by https://github.com/twbs/bootstrap/blob/v4.6.0/scss/_reboot.scss#L257-L262.

Would it be possible to move reboot from under .bootstrap {}?

Carl-Hugo commented 3 years ago

It would be possible but will require some additional efforts to ensure both light and dark stylesheets are not creating conflicts as _reboot.scss is included in both. Moreover, at first glance, there seem to be some color variables involved in _reboot.scss, which may cause some conflicts. One example would be L52 and L54, and there are more.

That said, this could be fixed as part of some optimization related to #20 or #39, but my bandwidth is limited. I'll keep this in mind and hopefully find some time to move those items forward, including this one.