ForEvolve / bootstrap-dark

Bootstrap 4 dark theme that supports togging dark/light themes as well. There is no fluff, it changes the color of Bootstrap and that's it, no new thing to learn or unlearn, just Bootstrap, but Dark!
MIT License
299 stars 44 forks source link

dark-variables colors not respected in toggle-bootstrap-dark #54

Closed cVantez closed 1 year ago

cVantez commented 2 years ago

Since the bootstrap variables partial needs to be loaded first, the overrides of the color variables in dark-variables are not picked up by the $colors or $theme-colors maps. This in turn means the utility classes generated from those maps don't properly reflect the dark theme colors.

For example: toggle-bootstrap-dark.css line 2077-9:

.bootstrap-dark .btn-primary {
  color: #ced4da;
  background-color: #007bff;

But #007bff is the default blue, not the lightened version specified. It's possible this issue may affect other dark stylesheets, toggle-bootstrap-dark is just the one I've been using.

I believe this could be fixed by adding something like

$colors: () !default;
$colors: map-merge(
  (
    "blue": $blue,
    ...
  ),
  $colors
);

to _dark-variables.scss

Carl-Hugo commented 2 years ago

Thanks for reporting this issue. I'll investigate when I get the chance.

Carl-Hugo commented 1 year ago

I totally forgot about this issue; fixing it atm.

Carl-Hugo commented 1 year ago

PR #58 addresses this.