ForEvolve / bootstrap-dark

Bootstrap 4 dark theme that supports togging dark/light themes as well. There is no fluff, it changes the color of Bootstrap and that's it, no new thing to learn or unlearn, just Bootstrap, but Dark!
MIT License
299 stars 44 forks source link

Investigate a nav-pills issue #60

Open Carl-Hugo opened 1 year ago

Carl-Hugo commented 1 year ago
    Sorry to bother you again, sir, but you missed my first bug report:
.nav-pills .nav-link.active, .nav-pills .show>.nav-link {
    color: #fff;
    background-color: _is_used_from_light_theme_
}

Try to change color in light theme (in node modules to red). And check nav-pills in dark theme. For example, this code:

<ul class="nav nav-pills nav-fill">
  <li class="nav-item">
    <a class="nav-link active" href="#">Active</a>
  </li>
  <li class="nav-item">
    <a class="nav-link" href="#">Much longer nav link</a>
  </li>
  <li class="nav-item">
    <a class="nav-link" href="#">Link</a>
  </li>
  <li class="nav-item">
    <a class="nav-link disabled">Disabled</a>
  </li>
</ul>

Again, I don't need this, but it would be responsible to fix obvious bugs. Furthermore, I think you should add nav-pills code https://getbootstrap.com/docs/4.6/components/navs/ to your samples

Have a nice day!

Originally posted by @AucT in https://github.com/ForEvolve/bootstrap-dark/issues/57#issuecomment-1318268562