search

ForLoveOfCats / SkyOfSteel

Git repo and bug tracker for SkyOfSteel
https://skyofsteel.org
MIT License
42 stars 11 forks source link

Completely added controller support without destroying the repo #38

Closed finnbainbridge closed 5 years ago

finnbainbridge commented 5 years ago

Added basic controller support (API may need to be improved on later). I've checked all the changes, and they're all things I've changed.

ForLoveOfCats commented 5 years ago

I've realized that to make this fit in with the rest of SkyOfSteel would require a rewrite to the point that it would not be your PR anymore. I don't want the trickyness of rewriting this piece at a time nor discredit you once this were to be merged.

ForLoveOfCats commented 5 years ago

I'm not closing the PR but I'm also not going to merge it (yet) or work any further on it myself (currently)

ForLoveOfCats commented 5 years ago

I'm going to close this so that when you rewrite this (as you stated on Discord that you intend to) what changes you made originally are preserved in this PR for historical reasons.

Apologies for taking so long to get the bind system ready for this to be rewritten, I was preparing for a test. The system should be ready by the end of the day. Check https://github.com/ForLoveOfCats/SkyOfSteel/issues/39 for more details.

ForLoveOfCats commented 5 years ago

The bind system has been rewritten