The current bind internals are a bit messing and have a few areas where failure could be easily introduced in the future. This must be remedied in addition to moving from (FunctionName, Key) to (Key, FunctionName). This has already been done cosmetically with https://github.com/ForLoveOfCats/SkyOfSteel/commit/7c3708112796186059d872db1d0d2cd4babffd42 but the internal behavior has not changed. This is important as (Key, FunctionName) allows us (by implying to the user) that multiple keys can be bound to the same action but only one action per key (which is required for controller support as the system should allow the keyboard and controller to both drive the same actions).
ForLoveOfCats
commented
5 years ago
The current bind internals are a bit messing and have a few areas where failure could be easily introduced in the future. This must be remedied in addition to moving from (FunctionName, Key) to (Key, FunctionName). This has already been done cosmetically with https://github.com/ForLoveOfCats/SkyOfSteel/commit/7c3708112796186059d872db1d0d2cd4babffd42 but the internal behavior has not changed. This is important as (Key, FunctionName) allows us (by implying to the user) that multiple keys can be bound to the same action but only one action per key (which is required for controller support as the system should allow the keyboard and controller to both drive the same actions).