Closed trotsiuk closed 6 years ago
@trotsiuk parameters: Do you mean that the order of the parameters should be the same of the description file? yes we can do it.
thinning: it is just a template for now. it should work but I didn't test it properly yet. We can skype, or you can change it and try.
data_climate: Yes, it make sense when you run for many many sites.
Thank you for reply @checcomi I will think about adjusting some more things. Currently will try to run a bit more of test
Good that you @trotsiuk are further testing the package. I'll pull soon a new version with all the outputs.
I have documented a bit more different data and functions as well as cleaned the example and vignette. Couple of things not implemented but I would like to raise:
parameters
. Currently the structure of the parameter table is very different from the original description file and the xcell version input. I wonder if we can consolidate and make it more consistent (which will require editing the fortran variable declaration) with original. Otherwise it took me a while to identify what is what. There are also variables I'm not sure what they mean, maybe you can have a look.thinning
table have many siteID which are not in thedata_site
file, and the siteID fromdata_site
are not in thedata_thinning
file. Shall it be corrected?data_climate
.data_site
have a climateID assigned to it, but if I understood correctly it is only the order of the dimension in the tree-dimensional array ofdata_climate
. Shall we introduce the id (similar to siteId) that will be persistent? E.g. we can have a climate data called vallis1, kURG3