Closed rexim closed 8 years ago
There're some minor issues regarding the established code style (some of them are common practices and some of them're common rules I choose for this project):
new BulletModel (this)
should be new BulletModel(this)
{
onto the new line, except trivial properties like int Foo { get; set; }
and one-line object expressions like new Barmaley { Foo = bar }
:
in declarations: class BulletModel : IModel
None of the issues are critical and there's no urgent need to fix them; please consider them when writing new code.
@ForNeVeR I think we are ready for the final review! I covered with UTs only what I saw makes sense to cover. Let me know if more is needed.
I second this!
Thank you! Rebased on develop.
To Do:
BulletSpaceModel
@ForNeVeR even though this PR is WIP I'd like to ask you to review it anyway and provide as many comments and suggestions as possible. Since this is my first experience with C# I probably made lots of mistakes. Thanks!
Close #5