ForNeVeR / TankDriver

Simple game about tanks.
MIT License
3 stars 2 forks source link

Introduce shooting #20

Closed rexim closed 8 years ago

rexim commented 8 years ago

To Do:

@ForNeVeR even though this PR is WIP I'd like to ask you to review it anyway and provide as many comments and suggestions as possible. Since this is my first experience with C# I probably made lots of mistakes. Thanks!


Close #5

ForNeVeR commented 8 years ago

There're some minor issues regarding the established code style (some of them are common practices and some of them're common rules I choose for this project):

None of the issues are critical and there's no urgent need to fix them; please consider them when writing new code.

rexim commented 8 years ago

@ForNeVeR I think we are ready for the final review! I covered with UTs only what I saw makes sense to cover. Let me know if more is needed.

Newlifer commented 8 years ago

I second this!

ForNeVeR commented 8 years ago

Thank you! Rebased on develop.