Box and derived type should be immutable

ForNeVeR / xaml-math

A collection of .NET libraries for rendering mathematical formulae using the LaTeX typesetting style, for the WPF and Avalonia XAML-based frameworks

MIT License

637 stars 100 forks source link

Box and derived type should be immutable #404

Open Orace opened 1 year ago

Orace commented 1 year ago

Box and derived type should be immutable. This property setters and methods should only be called in the constructor / at init:

[ ] Add
[ ] Source
[ ] Foreground
[ ] Background
[ ] Italic
[ ] Width
[ ] Height
[ ] Depth
[ ] Shift

ForNeVeR commented 1 year ago

Yep, I approve this. We've been having a similar problem with Atom type, and that's been resolved recently (with C# records). I think a similar approach should work for boxes?

Keep an eye on how selected boxes highlighting works, though. I remember something weird about that.