search

ForNeVeR / xaml-math

A collection of .NET libraries for rendering mathematical formulae using the LaTeX typesetting style, for the WPF and Avalonia XAML-based frameworks
MIT License
637 stars 100 forks source link

Sealed exception types in `XamlMath.Shared\Exceptions` #431

Closed Lehonti closed 1 year ago

Lehonti commented 1 year ago

Also, modernized namespace references (they are now file-scoped).

P.S. I don't know what is causing the build errors. Does sealing exception classes do anything that may cause them?

ForNeVeR commented 1 year ago

P.S. I don't know what is causing the build errors. Does sealing exception classes do anything that may cause them?

By sealing the classes, you've formally broken code compatibility: before that, the user code could inherit from these classes, but now it cannot.

I sincerely hope nobody actually inherited from them, so I believe we can safely merge this without bumping the major version 😅