search

ForbesLindesay / browserify-middleware

express middleware for browserify, done right
http://browserify.org
MIT License
381 stars 66 forks source link

upgraded from uglify-js to uglify-es so we can support minifying ES6 for production mode #118

Closed pigeonman99 closed 6 years ago

pigeonman99 commented 6 years ago

upgraded from uglify-js to uglify-es so we can support minifying ES6 for production mode. please kindly review.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 91.102% when pulling ac464c5d1f2be6884b1f6056e4ac188c63924da2 on pigeonman99:master into d63b1430210e664984c0a1b2fa3ef3e63f71e271 on ForbesLindesay:master.

ForbesLindesay commented 6 years ago

Can you fix the failing test for "options.noParse speeds things up by at least a factor of 5 (for jQuery)". I think it's probably fine to just update that to be a factor of 4. The point of the test is just that noParse should make things way faster, but uglify-es makes both slower.

pigeonman99 commented 6 years ago

@ForbesLindesay updated options.noParse test to factor of 4 and the checks passed. please review.

ForbesLindesay commented 6 years ago

Thanks for the contribution. Released as 8.1.0