search

ForbesLindesay / browserify-middleware

express middleware for browserify, done right
http://browserify.org
MIT License
381 stars 66 forks source link

added support for options.extensions #22

Closed refractalize closed 10 years ago

refractalize commented 10 years ago

From the browserify docs:

opts.extensions is an array of optional extra extensions for the module lookup machinery to use when the extension has not been specified. By default browserify considers only .js and .json files in such cases.

ForbesLindesay commented 10 years ago

Thanks for this, should the same option be applied to bundleModule?

refractalize commented 10 years ago

bundleModule... I wasn't sure about this - I'm not very familiar with bundling modules. I wasn't sure that you could bundle local modules (i.e. ones starting with ./) so I thought support for non-js extensions was not going to be needed. I'll take your advice on this tho!

ForbesLindesay commented 10 years ago

Just before I saw your comment I added it myself. I think it's far less likely to be needed, and I wouldn't use it as an example in the docs, but it should probably be still work.

Thanks again for the awesome contribution :smile:

refractalize commented 10 years ago

No problem, thanks for merging!