search

ForbesLindesay / browserify-middleware

express middleware for browserify, done right
http://browserify.org
MIT License
381 stars 66 forks source link

Fix reservedKeys logic #7

Closed mhart closed 11 years ago

mhart commented 11 years ago

This was preventing settings actually having any effect at all

ForbesLindesay commented 11 years ago

Released as 1.8.3

mhart commented 11 years ago

Great! Settings should finally be working :-)

It's a hairy bit of code to be honest... Would be a lot better with a few unit tests I'd say...

ForbesLindesay commented 11 years ago

Yep, I'll happily accept a few more unit tests. I wrote tests for the cache logic as that was especially complex, but I ran out of patience to do the rest of those tests https://github.com/ForbesLindesay/browserify-middleware/blob/master/test/settings.js