search

ForbesLindesay / browserify-middleware

express middleware for browserify, done right
http://browserify.org
MIT License
381 stars 66 forks source link

Options can sometimes be booleans #71

Closed gabegorelick closed 9 years ago

gabegorelick commented 9 years ago

Browserify allows some options, like noParse to be booleans. This patch makes sure that if you pass a boolean option, it isn't wrapped in an array (which would make no sense anyway).

Fixes #69

gabegorelick commented 9 years ago

Sorry for not adding a test case. I had no idea where to put one.

ForbesLindesay commented 9 years ago

Would you like to be added as a collaborator on this project, to help review and merge pull requests?

gabegorelick commented 9 years ago

Sure. Happy to help.

ForbesLindesay commented 9 years ago

Cool, you're added. Please follow these rules:

  1. never commit directly to master unless you're only editing documentation, or you're in the process of cutting a new release.
  2. never merge your own pull request unless it's had no comments from any collaborators for at least 24 hours.
  3. If you cut a new release, make sure you update History.md and follow semver when updating the version number.

If you let me know your npm username I'll add you as an owner so you can release new versions :)