search

ForbesLindesay / cabbie

WebDriver for the masses
https://cabbiejs.org/
MIT License
70 stars 11 forks source link

Tidied up cookie methods a bit. Added getCookie which is not in the wire-protocol, but is quite useful. #2

Closed maxnachlinger closed 10 years ago

ForbesLindesay commented 10 years ago

I've added a couple of comments, it would also be awesome to have some tests to go with these, but if you don't get time I'll accept the contribution and then add tests later. (P.S. tests would have caught some of the errors I've pointed out).

ForbesLindesay commented 10 years ago

The tests should set a few cookies and check that we can get them back again, as well as checking that if we ask for a cookie that doesn't exist, we don't get anything back.

maxnachlinger commented 10 years ago

Thanks for the feedback, that's a great point I'll put in some tests, make the changes you suggested, and kick you another pull request.