Allow specifying which key optimist uses in acitons

ForbesLindesay / redux-optimist

Optimistically apply actions that can be later commited or reverted.

MIT License

776 stars 39 forks source link

Allow specifying which key optimist uses in acitons #9

Closed quicksnap closed 7 years ago

quicksnap commented 8 years ago

I hoisted up matchesTransaction so it has access to the mapper. Also, real-world 2 uses a custom key, in addition to all the "basic tests". So, custom and default keys are somewhat evenly distributed.

I haven't tested outside of the test suite yet.

slightlytyler commented 8 years ago

I've tested this and found no issues. Would love to get this merged in! @ForbesLindesay @quicksnap

ktersius commented 8 years ago

Why is this not merged yet? Would also like to use this.

slightlytyler commented 8 years ago

@ktersius I've forked the repo for the time being and published with these changes https://www.npmjs.com/package/redux-optimist-prime

gillchristian commented 8 years ago

Any progression on this?

quicksnap commented 7 years ago

Closing to get it off my PR list. Feel free to reopen and merge if anyone ever wants to!