search

Forceu / barcodebuddy

Barcode system for Grocy
GNU Affero General Public License v3.0
433 stars 58 forks source link

Grocy 4.0.1 causes barcode buddy to crash #219

Closed mattkellaway closed 1 year ago

mattkellaway commented 1 year ago

Hi all, I recently upgraded to the latest grocy version and realised it has killed barcode buddy - the 4x version has removed the column _factor_purchase_to_stock and it’s no longer part of the API, which BB expects in the response.

this causes barcode buddy to just 500 error and effectively die if you scan a product that has been added after the new version has been installed, as it expects the quantity field in the API response. From my tinkering it needed the DB and config removed in order to begin working again.

I downgraded grocy and got barcode buddy working again, but it’s a temporary solution.

I will grab some logs tomorrow and dig through the PHP to provide both logs and detail, but I just wanted to start the issue in case someone else has already started working on it. I was thinking of dusting off my PHP and defaulting the quantity to 1 to avoid the crash, but I’m not sure that PR would be accepted.

Forceu commented 1 year ago

Thanks, I haven't had the time to upgrade my grocy instance yet, but I already suspected that this is a breaking change. I will update Barcode Buddy soon to be compatible.

Forceu commented 1 year ago

Fixed in 3fed0d1, sorry for the delay