search

Forceu / barcodebuddy

Barcode system for Grocy
GNU Affero General Public License v3.0
433 stars 58 forks source link

Quantity unit conversions #255

Open arcnmx opened 1 month ago

arcnmx commented 1 month ago

This is just a rough attempt at using the amount and quantity configured in grocy's product barcode for purchase and consume amounts. This likely relates to #209/#161/#123. Adding a config toggle that uses the default consume/purchase quantity+amount instead of the barcode's would probably make sense to address #215 as well.

jtitley commented 2 weeks ago

@Forceu bump on this.

Forceu commented 2 weeks ago

Hi, thanks for the PR. This is still set as draft, is it ready for review?

arcnmx commented 6 days ago

It should at least be ready for a preliminary review - most of the reason that it's marked WIP is because I'm looking for some initial feedback on whether the approach is worth polishing up for submission. The code itself is basically ready as-is (besides the potential inclusion of settings to customize the behaviours mentioned previously), it mostly just needs some polish and clean-up in the form of formatting and more documentation before I'd consider it "ready".