search

Forceu / barcodebuddy

Barcode system for Grocy
GNU Affero General Public License v3.0
431 stars 58 forks source link

Allow localization #90

Open yarons opened 4 years ago

yarons commented 4 years ago

Please add some i18n framework to allow localization of the product.

Thank you!

PiAir commented 2 years ago

I noticed a pull request #119 was created for this issue that hasn't made it into a release yet. What kind of help is still wanted there?

yarons commented 2 years ago

It looks great, now we can either leave it like that or connect it to a localization platform to ease the translation: Weblate and TranslateWiki are open source, Weblate offers commercial support while TranslateWiki doesn't. Transifex and Crowdin, both closed source with free open source hosting.

I think it's better to wait until @olekenneth will finish his localization prep and we can add it when all the files are ready for localization and the PO file is as wide-spread as possible.

PiAir commented 2 years ago

I think it's better to wait until @olekenneth will finish his localization prep and we can add it when all the files are ready for localization and the PO file is as wide-spread as possible.

Sure (and it was not that I was looking for work, just was interested in having a localized version so I can send the log messages to my Home Mini). I was asking because the last update of that pull request was from almost a year ago and I wasn't sure if it was still being worked on.

olekenneth commented 2 years ago

I think I got it working. I'll try to find the code and commit it

yarons commented 2 years ago

Cool, do you need my assistance with Weblate migration or any other platform? @comradekingu

olekenneth commented 2 years ago

I used this: https://www.transifex.com/olekenneth/teams/117391/nb_NO/

yarons commented 2 years ago

It's inaccessible for me, can you make this project public so I can join?

olekenneth commented 2 years ago

I'm not sure if that's possible? I can invite a username or email to my team. Maybe switch to better platform?

yarons commented 2 years ago

Weblate is fully open source and allows 30 days before confirming your open source license. Transifex organizations can be published, this is my organization: https://www.transifex.com/yaron/

comradekingu commented 2 years ago

Happy to help if you use Weblate. Either set up shop on https://weblate.bubu1.eu/ or https://hosted.weblate.org/hosting/ and add "kingu". Transifex is the worst of all possible options.

olekenneth commented 2 years ago

Maybe @Forceu will create that? Doesn't make sense for me to control it.

Forceu commented 2 years ago

Sorry guys that I haven't looked into this much any sooner. Unfortunately I do not have a lot of spare time for this project at the moment. I created a hosted version with Weblate which can be accessed at https://hosted.weblate.org/projects/barcode-buddy/

I added @comradekingu as an administrator, let me know your usernames so I can add you as well

yarons commented 2 years ago

Cool, mine is @Yaron.

There are no components yet, we may need your help adding the appropriate git permissions.

Forceu commented 2 years ago

Thanks I added you as well. I am not sure how exactly to add the components, I assume I entered something incorrectly; do you know how to add a component (or can you do it from the weblate interface)?

image

PiAir commented 2 years ago

I created an account @PiAir at weblate also, but maybe it's best to leave me as non-administrator so you have someone to test it from that end as soon as you've set it up?

Vertaalstatus

comradekingu commented 2 years ago

Up and running now on https://hosted.weblate.org/projects/barcode-buddy/ Are there any other strings/resources to add? Where are the Android strings?

nb_NO translation without a firm understanding of what "consume" constitutes also made. Should arrive as a PR.

@Forceu If you can add a webhook, as per https://docs.weblate.org/no/latest/admin/continuous.html#github-setup and merge https://github.com/Forceu/barcodebuddy/pull/185 (merged) I think that will do.

Possibly the https://github.com/weblate user needs to be added to the org. Sometimes GitHub complains about that, but I don't know why and when.

PiAir commented 2 years ago

Dutch also done.

Vertaalstatus

Forceu commented 2 years ago

Awesome, thanks a lot guys! I will do the German translation tomorrow and then have a look on how to integrate it into Barcode Buddy.

yarons commented 2 years ago

That's awesome, I would also like to help with RTL, is there a way to add "dir=rtl" to the HTML/body tag when Hebrew is selected? this way I can make those changes without modifying the LTR (English) CSS stylesheet.

Forceu commented 2 years ago

First of all thanks to everyone who helped translating! In the last months I haven't had enough time to incorporate the translations, but I have not forgotten about it. As soon as I have enough time (or someone creates a PR), this will be merged.