Branch for latest version of velodyne_pointcloud compatible (ros-noetic)

Ford / AVData

Autonomous Vehicle Seasonal Dataset

MIT License

293 stars 68 forks source link

Branch for latest version of velodyne_pointcloud compatible (ros-noetic) #22

Closed Chris7462 closed 3 years ago

Chris7462 commented 3 years ago

Hi all,

Since I'm using ros-noetic, I'm wondering if there is a branch compatible for latest version of velodyne_pointcloud?

As far as I know, CloudNodelet has been removed from velodyne_pointcloud in velodyne-1.6.0 as transform node includes all features of cloud node. As a result, multi_lidar_convert.launch is not working and all nodes that load velodyne_pointcloud/CloudNodelet need to be changed.

I've checked velodyne-model-fix branch, but it does not have such changes.

Thanks in advance

ankitvora7 commented 3 years ago

Hi @Chris7462 - Apologies for the delayed response but I want to check if you were able to solve this issue ? If yes, please feel free to submit a PR

ankitvora7 commented 3 years ago

We have also pushed a noetic-devel branch that should work with the velodyne package

Chris7462 commented 3 years ago

Hi @ankitvora7, I think the value of "/lidar_red" should be changed to "lidar_red" in the multi_lidar_convert.launch file as below and the same for "/lidar_yellow", "/lidar_blue", and "/lidar_green".

After the change, the branch works for me.

ankitvora7 commented 3 years ago

Good catch @Chris7462 ! That's a typo there. Will correct it and push the update to the branch.

Chris7462 commented 3 years ago

Thank you @ankitvora7 ! This issue can be closed. Really appreciate it!